Theme Templates: Fix display issues of Offline & Day of Event templates across themes #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
[Status] Needs Review
[Component] Theme Templates
coreymckrill
previously requested changes
Jan 13, 2020
Twenty Twenty uses a much different markup format for pages, so it's easier to match by using an entirely separate template. This approach should be considered a "patch", if the PWA merges into core, default themes will provide these templates.
ryelle
force-pushed
the
update/global-templates-theme-support
branch
from
a823732 to
3755ab3
Compare
|
Okay, I've removed the Day of Event template, and tweaked the offline template so that it's very, very simple. I'll update the description to reflect the actual PR now. |
I think that's fine, only 3 sites in my "2019+" dataset use Twenty Twelve… and it's not totally unreadable, just not great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The templates on some default themes use different markup, which causes display issues when trying to use the same templates across themes. To fix this, we should stop trying to fully emulate all themes. This PR removes the global Day of Event template, since the Day of Event stub is created and can use a regular page template. The offline page is called differently, but instead of trying to match the theme directly, we can create a very simple page, which inherits the basic style of the active theme.
Fixes #205, fixes #206
Twenty Thirteen
Twenty Fifteen
Twenty Seventeen
Twenty Twenty
How to test the changes in this Pull Request:
Day of Event:
Offline:
yoursite.wordcamp.test/?wp_error_template=offline